PYTHON-5413 Handle flaky tests#2395
Merged
blink1073 merged 40 commits intomongodb:masterfrom Jul 1, 2025
Merged
Conversation
ShaneHarvey
requested changes
Jul 1, 2025
Member
ShaneHarvey
left a comment
ShaneHarvey
left a comment
There was a problem hiding this comment.
Could we only enable flakey in CI and not locally? I worry having it run by default locally will make it more difficult to debug test failures.
| @async_client_context.require_failCommand_fail_point | ||
| @flaky(reason="PYTHON-5290", max_runs=3, affects_cpython_linux=True) | ||
| async def test_timeout_in_multi_batch_bulk_write(self): | ||
| if sys.platform != "linux": |
Member
There was a problem hiding this comment.
Could we do this only in Evergreen CI?
Member
Author
There was a problem hiding this comment.
Updated this and added logic/docs around enabling and disabling the flaky decorator.
ShaneHarvey
approved these changes
Jul 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal was to get the following to pass on multiple restarts:
Since these are the most flaky builds in the waterfall currently. The current build has passed three times for the above variants.